Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maintenance] E2E tests aren't running on Version Packages PR #219

Open
1000hz opened this issue Dec 13, 2023 · 0 comments
Open

[maintenance] E2E tests aren't running on Version Packages PR #219

1000hz opened this issue Dec 13, 2023 · 0 comments
Assignees

Comments

@1000hz
Copy link
Contributor

1000hz commented Dec 13, 2023

We use @changesets/action to open a PR that manages our versioning, which gets created/updated during a step of https://github.com/cloudflare/wrangler-action/blob/main/.github/workflows/release.yml. We also run our E2E tests via a workflow that runs on pull_request events. It turns out that GitHub avoids triggering workflows from events generated by other workflows when using the automatically provided GITHUB_TOKEN, which means E2E tests don't get triggered to run any time the Version Packages PR is opened or updated. Sad!

However, in late 2022 GitHub made an exception to allow workflows to be triggered via workflow_dispatch events even if GITHUB_TOKEN was used.

We should add a step to our release.yml workflow to send a workflow_dispatch event for the E2E workflow with a ref of changeset-release/main (following the example in the linked blog post above). We'll also need to ad a new on: workflow_dispatch trigger to our E2E workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants