Don't set packageManager default via action.yml
#193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1000hz
force-pushed
the
cina/fix-packagemanager-default
branch
from
4ebae9d
to
1814662
Compare
We need to distinguish between when the value is and isn't set in order to perform inference based on lockfile and only fallback to the default of npm if inference fails.
1000hz
force-pushed
the
cina/fix-packagemanager-default
branch
from
1814662
to
bd06b29
Compare
| required: false | ||
| default: npm |
petebacondarwin
approved these changes
Oct 11, 2023
Merged
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #190 I set
default: npmin action.yml, not realizing this sets the actual input value when it's not provided explicitly (as opposed to just serving as documentation) 🤦🏻♂️. This prevented lockfile inference from ever happening, since thepackageManagervalue would never be empty.This PR removes the default value, allowing the lockfile inference to happen before ultimately falling back to
"npm".