This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Add support for printing api token email on whoami
#1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- query the same api endpoint as we do with the global token, but now with the api token - return errors, print helpful statement if the api token doesn't have the right permission Closes #863
EverlastingBugstopper
suggested changes
Apr 20, 2020
There was a problem hiding this comment.
This looks great! I have a few pointers that should make this implementation a bit more idiomatic. After that's addressed we should be good to go :)
I haven't tested the code with the suggestions so some modifications may be necessary, would definitely test them out before accepting them :)
- headspace was in go lang with using "" for handling errors :P
EverlastingBugstopper
approved these changes
Apr 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #863