This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
suggest wrangler init if wrangler.toml does not exist
#1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleymichal
force-pushed
the
feat/error-no-toml
branch
from
a2f6cce
to
d916e36
Compare
ashleymichal
force-pushed
the
feat/error-no-toml
branch
from
d916e36
to
aba0165
Compare
| @@ -46,6 +46,10 @@ pub struct Manifest { | |||
|
|
|||
| impl Manifest { | |||
| pub fn new(config_path: &Path) -> Result<Self, failure::Error> { | |||
| failure::ensure!( | |||
| config_path.exists(), | |||
| "wrangler.toml not found; run `wrangler init` to create one." | |||
There was a problem hiding this comment.
nit: add link to docs about how to configure
| @@ -147,5 +147,5 @@ fn base_fixture_path() -> PathBuf { | |||
| } | |||
|
|
|||
| fn toml_fixture_path(fixture: &str) -> PathBuf { | |||
| base_fixture_path().join(fixture) | |||
| base_fixture_path().join(fixture).with_extension("toml") | |||
There was a problem hiding this comment.
why is this change necessary?
There was a problem hiding this comment.
some magical thing in config crate was doing this for us when we went to use merge, but now that we first check config_path.exists() before we get to that point, the extension needs to be explicitly included in the path.
EverlastingBugstopper
approved these changes
May 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #827