This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Reduce cognitive complexity in main #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces our massive clap App with a much simpler Cli struct that has all the same information in an easier to understand and modify format (types). Because everything is now typed (and because we've moved clap::App creation out of main), we can further reduce the cognitive complexity of main by removing lots of parameter checking and parsing, removing that pesky clippy lint attribute.
|
I'm currently going over and verifying the API hasn't changed at all. |
nilslice
reviewed
May 26, 2021
nilslice
reviewed
May 26, 2021
nilslice
reviewed
May 26, 2021
nilslice
suggested changes
May 26, 2021
@ObsidianMinor, can you confirm you saw no changes? |
nilslice
approved these changes
May 27, 2021
There was a problem hiding this comment.
Ok, confirmed offline with @ObsidianMinor that the API is consistent, and have observed the same with my testing. ✅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces our massive clap App with a much simpler Cli struct that
has all the same information in an easier to understand and modify
format (types). Because everything is now typed (and because we've moved
clap::App creation out of main), we can further reduce the cognitive
complexity of main by removing lots of parameter checking and parsing,
removing that pesky clippy lint attribute.
Also it removes emoji in all the help messages. But they don't always work
anyway (Windows) and prevent us from doing this necessary refactor,
so meh.