Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Made config add target_type to type instead of "target_type" #1988

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Made config add target_type to type instead of "target_type" #1988

merged 3 commits into from
Jul 7, 2021

Conversation

jspspike
Copy link
Contributor

@jspspike jspspike commented Jul 2, 2021

Fixes #1960

We used serde to rename the target_type field to type but when making the toml ourselves we still used target_type

@jspspike jspspike requested a review from a team as a code owner July 2, 2021 18:50
caass
caass approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@caass caass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@caass caass merged commit bdda569 into cloudflare:master Jul 7, 2021
@jspspike jspspike deleted the josh/init-type-fix branch July 7, 2021 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@caass caass caass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrangler init --type="javascript" doesn’t work as expected
2 participants
@jspspike @caass