This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Fix some migration errors #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xortive
commented
Nov 8, 2021
•
xortive
commented
- Don't include migrations in Target for preview/dev uploads
src/settings/toml/manifest.rs
Outdated
| @@ -349,6 +349,12 @@ impl Manifest { | |||
| if build.command.is_none() { | |||
| anyhow::bail!(error_message) | |||
| } | |||
| if matches!(build.upload, UploadFormat::Modules { .. }) { | |||
There was a problem hiding this comment.
This might not be true as of later tonight. We're landing #2126, and making a release of https://github.com/cloudflare/kv-asset-handler and will update the docs showing hwo it works with es modules.
xortive
force-pushed
the
malonso/fix-migrations-modules
branch
from
8f84b08
to
f86efc7
Compare
xortive
force-pushed
the
malonso/fix-migrations-modules
branch
from
f86efc7
to
dfa7344
Compare
threepointone
approved these changes
Nov 9, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.