This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Get https websockets working #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
approved these changes
Dec 9, 2021
|
Happy to stamp and land this if you can rebase and fix the conflict, thanks @jyn514 |
It turns out websocket upgrades with HTTP/2 require an HTTP extension, which Cloudflare doesn't currently support: https://datatracker.ietf.org/doc/html/rfc8441 To avoid this, enable HTTP/1 for the remote client. This required an update to rustls to allow enabling http1.
jyn514
force-pushed
the
jnelson/https-websockets
branch
from
1bfdf92
to
28a1b6f
Compare
|
Thanks! Fixed the conflict :) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out websocket upgrades with HTTP/2 require an HTTP extension,
which Cloudflare doesn't currently support: https://datatracker.ietf.org/doc/html/rfc8441
To avoid this, enable HTTP/1 for the remote client.
This required an update to rustls to allow enabling http1.
Fixes #1910 (cc #2135).