This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Check for updates in the foreground, not the background #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids creating a new OpenSSL context while the main thread exits the process.
jyn514
force-pushed
the
jnelson/foreground-update
branch
from
9c1d737
to
f1d3cb5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids creating a new OpenSSL context while the main thread exits the process.
The issue that #2161 ran into is that
try_recvis non-blocking, so it would exit the process before the spawned thread finished creating thereqwest::Client.Fixes #2161.