This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Have live reload preview watch over entire rust worker directory #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabbifish
added
regression
gabbifish
changed the title
xtuc
reviewed
Sep 9, 2019
| watcher.watch(&path, RecursiveMode::Recursive).unwrap(); | ||
| watcher.watch(&entry, RecursiveMode::Recursive).unwrap(); | ||
| message::info(&format!("watching {:?} and {:?}", &path, &entry)); | ||
| watcher.watch(RUST_PATH, RecursiveMode::Recursive).unwrap(); |
There was a problem hiding this comment.
I guess this watches target as well?
Could we ignore dotfiles as well? To avoid Vim's swap (btw you can turn it off in the settings) or similiar.
There was a problem hiding this comment.
It looks like the notify crate doesn't allow us to ignore dotfiles :(
https://docs.rs/notify/5.0.0-pre.1/notify
xtuc
reviewed
Sep 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #522.
This change has the live reload functionality watch over the entire rust worker directory, and does not look for package.json files that do not typically exist for rust wasm projects.