This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Use binary-install for npm #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
requested review from
ashleygwilliams,
xtuc,
ashleymichal and
gabbifish
EverlastingBugstopper
force-pushed
the
avery/use-binstall
branch
from
8a42efd
to
110db16
Compare
EverlastingBugstopper
force-pushed
the
avery/use-binstall
branch
3 times, most recently
from
0a9f37f
to
b7fc988
Compare
EverlastingBugstopper
force-pushed
the
avery/use-binstall
branch
from
b7fc988
to
b88de95
Compare
EverlastingBugstopper
changed the title
ashleygwilliams
approved these changes
Dec 12, 2019
ashleymichal
approved these changes
Dec 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use binary-install for npm installs of wrangler.
The overarching goal is to have this package also be used by wasm-pack, and by extension, wasm-pack-plugin, so that we no longer need to install wasm-pack on webpack builds.
This PR also includes logic for uninstalling the downloaded binary after uninstalling.
Testing
To test this, uninstall all versions of wrangler
npm uninstall -g @cloudflare/wranglercargo uninstall wranglerCheck to make sure
which wranglersayswrangler not foundThen
cd npmandnpm install -g, and try runningwhich wrangler.