fix: fixes vendoring issue #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ko- @marten-seemann @alxdavids can you guys take a look? |
alxdavids
approved these changes
Oct 18, 2018
marten-seemann
approved these changes
Oct 18, 2018
Ko-
approved these changes
Oct 19, 2018
p503/consts.go
Outdated
| @@ -23,6 +24,17 @@ const ( | |||
| NumWords = 8 | |||
| ) | |||
|
|
|||
| // CPU Capabilities. Those flags are reffered by assembly code. According to | |||
| // https://github.com/golang/go/issues/28230, variables reffered from the | |||
There was a problem hiding this comment.
Typo: referred. (2x here + 2x in p751)
* Assembly code can't reffer to variables which are not in the same package. * utils/cpu.go keeps flags indicating CPU capabilities. Currently this file keeps flags specific to X86, those flags are set only if program is run on X86, hence on ARM they always be false. Flags are coppied to variables which are local to P503 and P751 (so that assembly code can access them). * we dont need workaround in utils/utils.go anymore as utils/cpu.go is never ignored by the buildtags. See also: golang/go#28230 Fixes #21
|
Thnx guys! |
kriskwiatkowski
pushed a commit
to cloudflare/circl
that referenced
this pull request
Oct 24, 2018
fix: fixes vendoring issue * Assembly code can't reffer to variables which are not in the same package. * utils/cpu.go keeps flags indicating CPU capabilities. Currently this file keeps flags specific to X86, those flags are set only if program is run on X86, hence on ARM they always be false. Flags are coppied to variables which are local to P503 and P751 (so that assembly code can access them). * we dont need workaround in utils/utils.go anymore as utils/cpu.go is never ignored by the buildtags. See also: golang/go#28230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21