This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Be able to specify timeouts for acceptance tests without defaults in the spec. #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey simonjohansson! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/93914198. |
|
Hi @simonjohansson, Thanks for updating the changes since our last conversation. Unfortunately our pipeline is blocked right now, but we will pull in your changes once it becomes clear. @DanLavine && @utako, CF Runtime Team |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR (#652) got rejected
"It looks like we're already configuring the default timeouts in the CATS codebase, and we would like for that to be the source of truth for defaults. Could you please remove the defaults from the spec file to prevent any overlap? We'll be happy to pull in the PR after that."
@zrob
It seems the similar changes ended up in develop anyways
b6c1f33
Anyways, here is a new PR that addresses the issue that got raised.