Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

do reset the env values when --reset is used #10

Closed
wants to merge 1 commit into from

Conversation

hmalphettes
Copy link

When I use cf push --reset with a manifest I noticed that the environment variables were not re-applied as defined in the manifest.

This patch does apply the environment variables as defined in the manifest with a cf push --reset.

This PR was originally made against the vmc codebase in cloudfoundry-attic/manifests-vmc-plugin#2
@austinbv suggested I port it to cf.

@dmrschmidt
Copy link
Contributor

Thanks for your pull request! Right now however we cannot merge it in directly without sufficient test coverage. We still have this on our radar and will eventually come to implementing it, however we are currently very busy with other high-priority stories. So if you'd like to contribute and get this fix in we'd really appreciate specs added to the Pull Request and we can merge it in easily.

@hmalphettes
Copy link
Author

Ok: I was hoping you would say this :)

@mariash
Copy link
Contributor

mariash commented Jul 30, 2013

Closing for now. Please reopen if you want to add sufficient test coverage.

Thanks,
@mariash & @monkeyherder

@mariash mariash closed this Jul 30, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants