Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Improve code quality in start command #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NickyMateev
Copy link

Improve code quality in start command

While searching in the code a little bit, I noticed a few places where there was unnecessary branching of conditional statements, which were mutually exclusive.

In my opinion the code is more clear with the proposed change.

@cfdreddbot
Copy link

❌ Hey NickyMateev!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process.

The following github user @NickyMateev is not covered by a CLA.

After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s).

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/165589911

The labels on this github issue will be updated when the story is started.

@aemengo
Copy link
Contributor

aemengo commented Apr 25, 2019

Hey thanks for the contribution. I definitely agree with your line of thinking here.

If you get the CLA signed, we'll pull this commit right in.

@NickyMateev
Copy link
Author

NickyMateev commented Apr 25, 2019

Hey, as an employee of SAP I know that our company has already signed the CLOUDFOUNDRY.ORG FOUNDATION SOFTWARE GRANT AND CORPORATE CONTRIBUTOR LICENSE AGREEMENT (CCLA).

Is there anything additional I need to do?

@aemengo
Copy link
Contributor

aemengo commented Apr 25, 2019

The CLA instructions say to give the following a shot: https://help.github.com/en/articles/publicizing-or-hiding-organization-membership. And then resubmit the PR.

@NickyMateev
Copy link
Author

I've actually publicized my organization membership a long time ago (it's been at least a year since I did it), so that's something I've already done.

@aemengo aemengo self-requested a review June 22, 2020 17:54
@aemengo aemengo self-assigned this Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants