Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Add the app name to the bulk API response. #5

Merged
merged 1 commit into from

3 participants

@andreacampi

Specs are green.

The app name is not so confidential or so implementation-specific that we need to hide it.
Vice versa it is very useful to include in the bulk API as it makes it possible to correlate a droplet to an app.

@d
d commented

Hi Andrea,
What's your use case for this change? The targeted audience of bulk api is health manager and HM doesn't care about an app's name (which isn't globally unique).

Jesse

@andreacampi

I have a "CF Ops console" (https://github.com/andreacampi/InsideCF) that among other things lists running apps per DEA, regardless of the user that started them. This is mostly to aid in tracking down where an app is running.
As most of our infrastructure, this is not meant for end users, only for our Ops staff.

The way it works is to listen to CC and DEA announcements on NATS; but these only include app id and droplet id.
Humans are not particularly good at thinking and talking about UUID's, so the app name is a useful piece of information.
Unfortunately the app name is never visible (other than by accessing the CC DB, which I would like to avoid).

The app name used to be included in bulk api until commit cbcd543 that changed this code to an explicit whitelist.

I do get your point about the app name not being globally unique.
In my use case, this is mostly for convenience so it doesn't really have to be--the operator looking at the console knows to verify that. Still, it's usually "good enough".
As soon as I move to CC v2 I will look into also showing the organization and space (that should make it globally unique I think).

@cf-frontend

have you tested this with HM next?
btw even if we merge this, CCNG will not send this attribute out, can you make sure your console will not blow up when name is absent?

@andreacampi

have you tested this with HM next?

Good question, I think I have but I will verify again.

btw even if we merge this, CCNG will not send this attribute out, can you make sure your console will not blow up when name is absent?

Indeed InsideCF does not blow up--it just doesn't show this piece of information.
As soon as I switch to CCNG I will also make this change there, and submit a pull request for that too :)

@andreacampi

I can confirm this works with HM next.
In my private installation of CF I have the CC with this patch applied, and I've been running HM next for a few days. I also have my InsideCF running that makes use of this info.
It all works nicely together, no errors from the HM when fetching bulk info.

@cf-frontend cf-frontend merged commit 3d92ce2 into cloudfoundry-attic:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 16, 2013
  1. @andreacampi

    Add the app name to the bulk API response.

    andreacampi authored
    Specs are green.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  cloud_controller/app/controllers/bulk_controller.rb
View
2  cloud_controller/app/controllers/bulk_controller.rb
@@ -59,7 +59,7 @@ def hash_apps_by_id(arr)
def hashify_app(app)
h = {}
- [:id, :instances, :state, :framework, :runtime, :memory, :package_state, :updated_at
+ [:id, :name, :instances, :state, :framework, :runtime, :memory, :package_state, :updated_at
].each {|field| h[field] = app.send(field) }
h[:version] = app.generate_version
Something went wrong with that request. Please try again.