This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
respect the CLOUD_CONTROLLER_CONFIG environment variable #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. We'll pull this in shortly. |
|
The flow that requires this change is a bit odd. We are going to clean up the surrounding callers of this instead of taking this directly. Thanks for the pull request and highlighting the strangeness in the config between the cc and services. |
|
A better fix would be to remove the extraneous |
dsboulder
pushed a commit
that referenced
this pull request
Apr 1, 2013
git shortlog e5d71831a19f9a59cf757b4e2bd25b2af32f1611..HEAD
CloudFoundry Services Team (1):
Merge pull request #2 from SlimYang/master
David Stevenson and Matt Royal (1):
Added optional unique_id as part of a service offering & provision
Jesse Zhang and Scott Calvert (1):
Add CreateSnapshotV2Request JsonMessage
Yang Yang (1):
add message for service update handle in v2 api
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required if one is to use a custom cloud controller config file, especially to use a real domain instead of api.vcap.me.