This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Properly handle $no_proxy/localhost in a user's environment. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user has $http(s)_proxy defined, vmc will often fail to target a local VCAP environment. The cause of this was that vmc was looking directly to the http_proxy or https_proxy environment variables without checking that the host was not in $no_proxy, nor checking whether the target resolved to localhost. Both of these checks are handled via the open-uri module's find_proxy() method.
|
pulled. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has $http(s)_proxy defined, vmc will often fail to target a local
VCAP environment. The cause of this was that vmc was looking directly to the
http_proxy or https_proxy environment variables without checking that the host
was not in $no_proxy, nor checking whether the target resolved to localhost.
Both of these checks are handled via the open-uri module's find_proxy() method.