BOSH Password Confirmation

[tpradeep]

Wrote a quick code.

[drnic]

Can you please remove this hard coded bit and restore the commented line that prompts?

[tpradeep]

Actually we don't need this line, don't know why I included this in the first place. But the reason I included the password prompt inside while loop is to make the user re-enter both the passwords again if he gets it wrong.
Suppose the passwords do not match, the user may have entered the actual password itself wrong by mistake and not realize it. It's not necessary that he always enters confirmation password wrong.

Thats what I thought. What do you think ? Other than this, did I break anything ?

[drnic]

At the moment in reviewing it on my iPhone over breakfast :) If you can clean it up I'll test it out later.

On Fri, Mar 8, 2013 at 7:20 AM, Pradeep Tummala notifications@github.com
wrote:

@@ -1143,9 +1143,19 @@ def openstack?

   def prompt_for_bosh_credentials
     prompt = hl

•    settings[:bosh_password] = "yyy"
  

  Actually we don't need this line, don't know why I included this in the first place. But the reason I included the password prompt inside while loop is to make the user re-enter both the passwords again if he gets it wrong.
  Suppose the passwords do not match, the user may have entered the actual password itself wrong by mistake and not realize it. It's not necessary that he always enters confirmation password wrong.
  Thats what I thought. What do you think ? Other than this, did I break anything ?

  Reply to this email directly or view it on GitHub:
  https://github.com/StarkAndWayne/bosh-bootstrap/pull/154/files#r3298630

[drnic]

Why did you close it? Do you know you can keep pushing to the same branch and will update the PR? It's very clever!

[tpradeep]

It's not that clever. Go to repo, change branch then edit file. I know :) Wanted a clean PR (I know I am weird)

New PR
#155

[drnic]

Also, if I see the branch name is patch-1 or similar I assume you did it from GitHub rather than from editor; and I start being scared of whether you tested it at all :)

On Fri, Mar 8, 2013 at 8:07 AM, Pradeep Tummala notifications@github.com
wrote:

It's not that clever. Go to repo, change branch then edit file. I know :) Wanted a clean PR (I know I am weird)
New PR

#155

Reply to this email directly or view it on GitHub:
#154 (comment)

[tpradeep]

No. I test every thing before creating a PR. No particular reason for using
github though.
But my testing is limited to OpenStack only.

On Friday, March 8, 2013, Dr Nic Williams wrote:

Also, if I see the branch name is patch-1 or similar I assume you did it
from GitHub rather than from editor; and I start being scared of whether
you tested it at all :)

On Fri, Mar 8, 2013 at 8:07 AM, Pradeep Tummala <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>

wrote:

It's not that clever. Go to repo, change branch then edit file. I know
:) Wanted a clean PR (I know I am weird)
New PR

#155

Reply to this email directly or view it on GitHub:

#154 (comment)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/154#issuecomment-14627757
.

[drnic]

https://github.com/defunkt/hub is the tool I use to create pull requests.
Might be helpful for you to create multi-file pull requests.

git checkout -b
git push
hub pull-request

or

hub pull-request -i

[tpradeep]

Ah..thanks