This repository has been archived by the owner on Feb 10, 2022. It is now read-only.
Added missing obligatory setting for CF containers broker in accordan… #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce to their default.
|
Due to effect on Cloud Foundry broker completely not working now I do request final release after this patch applied (maybe with some better solution from release maintainer). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker broker does not perform any service operation on v26 like 'create service'.
Complain is about no 'container_env_var_dir' property in /var/vcap/jobs/cf-containers-broker/config/settings.yml.
Looking to src/cf-containers-broker/config it is easy to see that settings.xml contain appropriate setting which is not not a part of /jobs/cf-containers-broker/templates/config/settings.yml.erb.
It looks like this is only needed for some special case because appropriate directory dies not exists. But it helps broker so it performs its work.