Skip to content
This repository has been archived by the owner on Feb 10, 2022. It is now read-only.

using %> instead of -%> for fix for bosh director 1.3262.23.0 #84

Merged
merged 1 commit into from Jun 6, 2017

Conversation

svennela
Copy link
Contributor

I have reverted back below commit and tested changes with bosh director 1.3262.23.0 and with the latest version. It works fine.

ed6fb07

@mboldt
Copy link
Contributor

mboldt commented May 26, 2017

Just to add some context: in our tile-generator tool, we would like to use the latest docker-boshrelease (see cf-platform-eng/tile-generator#181), but the -%> ERB syntax is not supported by the ruby version in PCF 1.8, which is in support through end of June, so either (1) we keep the docker-boshrelease version pinned for another month or (2) we get this PR merged and we can get all the new docker-boshrelease goodness now.

@jhunt
Copy link

jhunt commented May 26, 2017

What version of ruby is in PCF 1.8?

@svennela
Copy link
Contributor Author

svennela commented May 26, 2017

ruby-2.1.7 in PCF 1.8

@drnic
Copy link
Contributor

drnic commented May 26, 2017 via email

@svennela
Copy link
Contributor Author

@drnic let me know if you have any questions on this.

Sridhar

@svennela
Copy link
Contributor Author

svennela commented Jun 5, 2017

@drnic can you help us with PR merge?

@drnic drnic merged commit 3d75518 into cloudfoundry-incubator:master Jun 6, 2017
@drnic
Copy link
Contributor

drnic commented Jun 6, 2017

PR is moving thru CI now. https://ci.starkandwayne.com/teams/main/pipelines/docker-boshrelease/resources/boshrelease see 3d7551854bbeabeda8f9071fa08920febe00caa7

@drnic
Copy link
Contributor

drnic commented Jun 6, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants