Enable Eirini to run on a BOSH VM #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Eirini needed to run from within the k8s cluster where workloads were scheduled. Recently, a change was made to the Eirini source to allow a kube.conf file to be specified, allowing Eirini to run outside of the target cluster (e.g., from a BOSH VM) This commit adds the following spec properties: - opi.k8s.host_url - opi.k8s.node_ca - opi.k8s.service_account.name - opi.k8s.service_account.token and generates kube.conf and CA certificate files on the BOSH VM from these values. Signed-off-by: Jaskanwal Pawar <jpawar@pivotal.io>
This bump of Eirini is required to allow Eirini to run outside the k8s cluster
|
Thank you @jenspinney for this PR! I tried to use this bosh release without setting any of the new properties and I get failures like: I guess there are some more |
- Should only render when the property which contains its value is actually set
|
@jimmykarily Woops, sorry about that. There is a template file corresponding to the value of Also, this latest commit bumped Eirini submodule again to be in line with current HEAD of Thanks, |
|
Works now, thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Eirini to run on a BOSH-managed VM. Recently, Eirini was modified to be able to run outside the k8s cluster (see cloudfoundry/eirini#52). This PR hooks that ability into the bosh release so that Eirini can run on a BOSH VM.
This is accomplished by generating a kube config file from the following new spec properties:
If those values are specified, kube config and CA certificate files are generated on the BOSH VM and hooked into the opi config.
This PR also bumps the Eirini submodule to be able to take advantage of the out-of-cluster support.