Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra attributes appearing in credential binding details #402

Closed
Dray56 opened this issue Apr 18, 2024 · 0 comments · Fixed by #403
Closed

Extra attributes appearing in credential binding details #402

Dray56 opened this issue Apr 18, 2024 · 0 comments · Fixed by #403

Comments

@Dray56
Copy link

Dray56 commented Apr 18, 2024

According to the cloudfoundry docs, there does not seem to be any well defined schema for the details of a service credential binding. Though credentials seem to be present in almost every managed service instance details and some user provided service instances if credentials had been passed during their creation, syslogDrainURL is specific to user provided service instances and the 3 attributes are not always present in every response.

type ServiceCredentialBindingDetails struct {
	Credentials    map[string]any `json:"credentials"`
	SyslogDrainURL string         `json:"syslog_drain_url"`
	VolumeMounts   []string       `json:"volume_mounts"`
}

Therefore better approach would be to add omit empty for them so that the attributes do not appear in the response when the api did not return them

Dray56 referenced this issue in Dray56/go-cfclient Apr 18, 2024
…nity#402

Signed-off-by: Ray <debaditya.ray@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant