Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added omitempty for binding detail attributes #403

Merged
merged 1 commit into from Apr 30, 2024

Conversation

Dray56
Copy link
Contributor

@Dray56 Dray56 commented Apr 18, 2024

fix #402

…nity#402

Signed-off-by: Ray <debaditya.ray@sap.com>
@sneal
Copy link
Contributor

sneal commented Apr 18, 2024

Adding omitemptydoesn't change the unmarshalling behavior https://go.dev/play/p/FN_z3LyA19Q

@Dray56
Copy link
Contributor Author

Dray56 commented Apr 19, 2024

True! In my case, I was actually marshalling the getdetails response back to a json and then doing some processing on it. That way it would be really helpful for consumers of this client.

@sneal sneal merged commit ab0b8b8 into cloudfoundry:main Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra attributes appearing in credential binding details
2 participants