Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CredentialString(key string) can not deal with multi-layer keys #23

Open
xiujiao opened this issue May 16, 2017 · 1 comment
Open

CredentialString(key string) can not deal with multi-layer keys #23

xiujiao opened this issue May 16, 2017 · 1 comment

Comments

@xiujiao
Copy link

xiujiao commented May 16, 2017

CredentialString(key string) only can get the first layer string values. It will be nice we can run Credential(key) to get nested credential with any type. for example Credential(protocols.amqp.uri)will get amqp://guest:guest@rabbitmq:5672,Credential(protocols.amqp.ssl) will get false

"VCAP_SERVICES": {
  "p-rabbitmq": [
   {
    "credentials": {
     "protocols": {
      "amqp": {
       "uri": "amqp://guest:guest@rabbitmq:5672"
       "ssl": false
      } }  } }]
}
@xiujiao
Copy link
Author

xiujiao commented May 19, 2017

I submit a PR to solve this issue. #24
Could you please take a look? @joefitzgerald @krishicks @ArthurHlt
Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant