Move gogs admin user creation into its own errand #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I haven't gotten to this PR yet. I'll try to look at it next week (and fix up CI). |
|
@shreddedbacon good news - I've fixed the CI and upgraded the base stemcell. Unfortunately for you -- I need you to rebase your PR against master so that CI can get the updated CI scripts from your branch. Possible for you to do this? I know you submitted the PR a long time ago. I'm sorry. |
|
Thanks @shreddedbacon If we're lucky enough to get more PRs from you in future, create a |
|
Want me to hold off on next gogs release until you're next PR? |
|
Yes please, I will work on the next PR over the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I went to use this bosh release, I found the admin user was not being created. #20 mentions this too
This moves the creation of the admin account out of
gogs_ctland into its own errand.I will also have follow up PR coming which adds the ability to specify authentication backends (LDAP, SMTP) which means this account creation can be optional.