Handle the case where "text_file" may be set, but the target file may be empty or missing. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be empty or missing.
|
Thanks! |
jmcarp
added a commit
to jmcarp/slack-notification-resource
that referenced
this pull request
Mar 22, 2018
…file may be empty or missing. (cloudfoundry-community#47)" This reverts commit 186adf7.
jmcarp
added a commit
to cloud-gov/cg-deploy-prometheus
that referenced
this pull request
Mar 22, 2018
Restore conditional notifications after logic was changed in cloudfoundry-community/slack-notification-resource#47.
jmcarp
added a commit
to jmcarp/slack-notification-resource
that referenced
this pull request
Mar 22, 2018
Before cloudfoundry-community#47, setting `text_file` to an empty or missing file resulted in no notification being sent. After cloudfoundry-community#47, setting `text_file` to an empty file continued to result in no notification, but setting to an empty file sent a notification. This patch updates docs and tests to clarify the current expected behavior around empty and missing text files.
jmcarp
added a commit
to cloud-gov/cg-pipeline-tasks
that referenced
this pull request
Mar 23, 2018
Restore conditional notifications after logic was changed in cloudfoundry-community/slack-notification-resource#47.
drnic
pushed a commit
that referenced
this pull request
Mar 23, 2018
Before #47, setting `text_file` to an empty or missing file resulted in no notification being sent. After #47, setting `text_file` to an empty file continued to result in no notification, but setting to an empty file sent a notification. This patch updates docs and tests to clarify the current expected behavior around empty and missing text files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.