Interpolate the content of text file
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR-testing pipeline job is broken but the build and tests are passing ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the content of
text_fileis interpolated the same waytextis.The change in
outis quite trivial, and we've added two automated tests to cover the new expected behavior.This new behavior may produce unexpected results when the content of the
text_fileincludes some environment variables that are to be printed verbatim and not expanded.We think that including variables like
$BUILD_PIPELINE_NAMEin the ù text_file` and expecting these to be printed verbatim in a Slack message is a very uncommon requirement. Thus, we expect the impact to be very limited.