Rename provider

[mevansam]

Pull request addressing issues: #44 and #66

[gberche-orange]

thanks @mevansam looks good to me. The failed test may require a merge of #89

For users such as @janosbinder that started to use mevansam/terraform-provider-cf in production, we should document a migration guide:

• TF specs need provider, resources and datasource renames
• TF state file requires
  • Provider rename
  • Resources rename

I suggest to track this into a distinct issue to merge #85 asap.

[gberche-orange]

I assume the sidebar_current ids are defined in cf.erb and therefore don't need renames

[mevansam]

For backward compatibility would it make sense to register providers under the cf_* name a well as cloudfoundry_*, until @janosbinder has moved over to the new naming convention? Theoretically, it should work but I have not tested it but wanted to validate if this has already been experimented with at Orange.

[gberche-orange]

@mevansam I would suggest to keep the provider code simple and compliant to hashicorp guidelines, and rather rely on beta users of mevansam/terraform-provider-cf to upgrade themselves using the procedure @janosbinder kindly contributed.

[ArthurHlt]

I do agree with @gberche-orange this is more complexity for us to maintain than for user to do the changes. In add, we will never remove it to ensure compatibility by doing. I think that the sooner the better here.

[janosbinder]

@gberche-orange @mevansam I think the necessary steps for migration are:

0, back up the tf files and the terraform.tfstate file
1, in all tf files replace resource/data "cf_..." with "cloudfoundry_...". For example sed 's#resource \"cf_#resource \"cloudfoundry_#g' old.tf | sed 's#data \"cf_#data \"cloudfoundry_#g'
2, in the terraform.tfstate file replace the types. For example "type": "cf_service_instance" should be replaced with "type": "cloudfoundry_service_instance"
3, in the terraform.tfstate file check the depends_on nodes and make the adjustments. For example

"depends_on": [
"data.cf_service.abc"
"cf_service_instance.xyz"
"cf_route.example"
],

Should be

"depends_on": [
"data.cloudfoundry_service.abc"
"cloudfoundry_service_instance.xyz"
"cloudfoundry_route.example"
],

4, if there are no errors after calling terraform plan, and no changes are planned to be applied then the migration was successful.