Stop downloading the app asynchronously #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that the schema.ResourceData is not thread safe, even for concurrent reads, due to internal memoization during reads. The result was that app creation would sometimes fail mysteriously with an "unexpected EOF" error due to the provider process crashing due to either concurrent map writes or read/write.
|
I hadn't realized there was a serious demand for this fix, but I'd be happy to open the PR myself if people would prefer. |
|
+1 @jcarrothers-sap 's fix was a great help for us. Issue opened here: #88 @mevansam @gberche-orange @psycofdj @ArthurHlt could you please review this PR? |
|
Hm, it seems that the acceptance environment has been not set up for travis as it is missing a lot of CF_... shell variables. |
|
Of course no problem with this! |
sleungcy
pushed a commit
to sleungcy/terraform-provider-cf
that referenced
this pull request
Jan 15, 2024
jira: FPA53-15823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here in this PR, I'm submitting the fix by Jim Carrothers @jcarrothers-sap (as filed in meeting notes from Monday April the 16th, 2018) that fixes a bug when downloading application files asynchronously in
resourceAppCreate().I submit this because the bug is quite severe and the fix wasn't proposed here in upstream yet.
Here are Jim's own words ab out the issue:
Best