This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Regenerate and tidy go.mod and go.sum #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides the cleanup the client-go checksum is regenerated with go 1.11.2 which will help with the docker build and CI. Developers using go 1.11.1 could also upgrade to 1.11.2 to not run into the checksum mismatch issue (1.11.1 seems to generate archives with different checksums than 1.11.0 and 1.11.2).
|
✅ Hey aduffeck! The commit authors and yourself have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/162602416 The labels on this github issue will be updated when the story is started. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the cleanup the client-go checksum is regenerated with go 1.11.2
which will help with the docker build and CI. Developers using go 1.11.1
could also upgrade to 1.11.2 to not run into the checksum mismatch
issue (1.11.1 seems to generate archives with different checksums than
1.11.0 and 1.11.2).
See golang/go#27925 (comment).