Merge pull request #95 from cloudfoundry-incubator/aduffeck/fix_memoi…

…zing_properties

Fix memoizing instance group properties

lib/bosh_deployment_manifest.rb

@@ -7,7 +7,7 @@ def initialize(path)
   end
 
   def properties_for_instance_group(instance_group_name)
-    return @properties[instance_group] if @properties && @properties[instance_group]
+    return @properties[instance_group_name] if @properties && @properties[instance_group_name]
 
     instance_group = @manifest['instance_groups'].find { |group| group['name'] == instance_group_name }
     return [] unless instance_group
@@ -22,7 +22,7 @@ def properties_for_instance_group(instance_group_name)
     end
 
     @properties ||= {}
-    @properties[instance_group] = properties
+    @properties[instance_group_name] = properties
   end
 
   private

spec/lib/bosh_deployment_manifest_spec.rb

@@ -12,4 +12,13 @@
 
     expect(manifest.properties_for_instance_group('server')).to eq(expected_properties)
   end
+
+  it 'memoizes instance group properties' do
+    manifest = described_class.new(File.expand_path('fixtures/bosh-deployment-manifest.yml', __dir__))
+    properties = manifest.properties_for_instance_group('server')
+
+    expect(manifest).to_not receive(:inject_properties)
+    memoized_properties = manifest.properties_for_instance_group('server')
+    expect(memoized_properties).to eq(properties)
+  end
 end