This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Replace bosh-template openstruct() method #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create a new object that replaces openstruct that can fallback to consul lookups
| @config_store = config_store | ||
| super(data) |
There was a problem hiding this comment.
You probably should add a comment on why 'super' has to go at the end of the method, as common practice is to call 'super' at the start of an initializer. Here it needs to appear after setting config_store.
|
LGTM |
ericpromislow
pushed a commit
that referenced
this pull request
Oct 14, 2015
Replace bosh-template openstruct() method
| expect(prop).to eq(5) | ||
| end | ||
|
|
||
| it 'should look up values in consul that don''t exist in properties' do |
There was a problem hiding this comment.
This is why I don''t mind object to using double-quotes in ruby
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consul lookups