This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Use the new service_name field for job providers
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us handle jobs with custom service names (for, e.g., "api" instead of "api-group-cloud-controller-ng")
SCF isn't in the same (GitHub) org as configgin anymore
|
Hey mook-as! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
jandubois
reviewed
Nov 7, 2018
| @@ -11,9 +11,10 @@ | |||
|
|
|||
| set -o errexit -o nounset | |||
|
|
|||
| REPO="${REPO:-scf}" | |||
| REPO="${REPO:-../../github.com/SUSE/scf}" | |||
There was a problem hiding this comment.
This default is making the assumption that configgin and scf repos are located in a $GOPATH/src style layout, which is somewhat questionable, given that neither of them are Go projects... It is also out-of-sync with the comment in line 8.
But whatever, it is user-overridable, so good enough for now.
jandubois
approved these changes
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires cloudfoundry-incubator/fissile#442
This makes the BOSH Links implementation support the custom service names.