Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Commit

Permalink
Uses gosteno logger for UaaTokenFetcher.
Browse files Browse the repository at this point in the history
- Also creates a New constructor for UaaTokenFetcher
  • Loading branch information
wfernandes committed Apr 26, 2016
1 parent 28c09d3 commit 8b723a0
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 25 deletions.
5 changes: 1 addition & 4 deletions datadogfirehosenozzle/datadog_firehose_nozzle_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@ var _ = Describe("Datadog Firehose Nozzle", func() {
fakeFirehose.Start()
fakeDatadogAPI.Start()

tokenFetcher := &uaatokenfetcher.UAATokenFetcher{
UaaUrl: fakeUAA.URL(),
}

config = &nozzleconfig.NozzleConfig{
UAAURL: fakeUAA.URL(),
FlushDurationSeconds: 10,
Expand All @@ -65,6 +61,7 @@ var _ = Describe("Datadog Firehose Nozzle", func() {
}
gosteno.Init(c)
log = gosteno.NewLogger("test")
tokenFetcher := uaatokenfetcher.New(fakeUAA.URL(), "un", "pwd", true, log)
nozzle = datadogfirehosenozzle.NewDatadogFirehoseNozzle(config, tokenFetcher, log)
})

Expand Down
7 changes: 1 addition & 6 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,7 @@ func main() {
log.Fatalf("Error parsing config: %s", err.Error())
}

tokenFetcher := &uaatokenfetcher.UAATokenFetcher{
UaaUrl: config.UAAURL,
Username: config.Username,
Password: config.Password,
InsecureSSLSkipVerify: config.InsecureSSLSkipVerify,
}
tokenFetcher := uaatokenfetcher.New(config.UAAURL, config.Username, config.Password, config.InsecureSSLSkipVerify, log)

threadDumpChan := registerGoRoutineDumpSignalChannel()
defer close(threadDumpChan)
Expand Down
29 changes: 20 additions & 9 deletions uaatokenfetcher/uaa_token_fetcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,37 @@ package uaatokenfetcher

import (
"github.com/cloudfoundry-incubator/uaago"
"log"
"github.com/cloudfoundry/gosteno"
)

type UAATokenFetcher struct {
UaaUrl string
Username string
Password string
InsecureSSLSkipVerify bool
uaaUrl string
username string
password string
insecureSSLSkipVerify bool
log *gosteno.Logger
}

func New(uaaUrl string, username string, password string, sslSkipVerify bool, logger *gosteno.Logger) *UAATokenFetcher {
return &UAATokenFetcher{
uaaUrl: uaaUrl,
username: username,
password: password,
insecureSSLSkipVerify: sslSkipVerify,
log: logger,
}
}

func (uaa *UAATokenFetcher) FetchAuthToken() string {
uaaClient, err := uaago.NewClient(uaa.UaaUrl)
uaaClient, err := uaago.NewClient(uaa.uaaUrl)
if err != nil {
log.Fatalf("Error creating uaa client: %s", err.Error())
uaa.log.Fatalf("Error creating uaa client: %s", err.Error())
}

var authToken string
authToken, err = uaaClient.GetAuthToken(uaa.Username, uaa.Password, uaa.InsecureSSLSkipVerify)
authToken, err = uaaClient.GetAuthToken(uaa.username, uaa.password, uaa.insecureSSLSkipVerify)
if err != nil {
log.Fatalf("Error getting oauth token: %s. Please check your username and password.", err.Error())
uaa.log.Fatalf("Error getting oauth token: %s. Please check your username and password.", err.Error())
}
return authToken
}
15 changes: 9 additions & 6 deletions uaatokenfetcher/uaa_token_fetcher_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,28 @@ package uaatokenfetcher_test

import (
"github.com/cloudfoundry-incubator/datadog-firehose-nozzle/uaatokenfetcher"
"github.com/cloudfoundry/gosteno"

"github.com/cloudfoundry-incubator/datadog-firehose-nozzle/testhelpers"
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
)

var _ = Describe("UaaTokenFetcher", func() {
var tokenFetcher *uaatokenfetcher.UAATokenFetcher
var fakeUAA *testhelpers.FakeUAA
var fakeToken string
var (
tokenFetcher *uaatokenfetcher.UAATokenFetcher
fakeUAA *testhelpers.FakeUAA
fakeToken string
fakeLogger *gosteno.Logger
)

BeforeEach(func() {
fakeLogger = testhelpers.Logger()
fakeUAA = testhelpers.NewFakeUAA("bearer", "123456789")
fakeToken = fakeUAA.AuthToken()
fakeUAA.Start()

tokenFetcher = &uaatokenfetcher.UAATokenFetcher{
UaaUrl: fakeUAA.URL(),
}
tokenFetcher = uaatokenfetcher.New(fakeUAA.URL(), "username", "password", true, fakeLogger)
})

It("fetches a token from the UAA", func() {
Expand Down

0 comments on commit 8b723a0

Please sign in to comment.