This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Set memory and cpu requests and limit values for all containers #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf-for-K8s is currently working on a scaling and Quality of Service (QoS) set of stories.
We are targeting 1.0 to be configured out-of-the-box as a "developer" edition aimed at those users who want to kick the tires. As part of this, we would like to set limits on mem/cpu.
Since a "developer" edition may not be preferred by everyone, we want each component to be configurable to scale both horizontally (replicas) and vertically (mem/cpu). This will also allow users to deliver a Guaranteed QoS when required (although we are recommending that all of our pods and containers use the Burstable QoS) As part of this we would like to ask you to do several things:
consider which of your pods/containers you would like to expose for
scaling properties for for both horizontal (deployment replicas) and vertical (mem/cpu request/limits).
expose said configuration properties.
sets mem and cpu values for all containers in order to provide as much meta-data to the k8s as possible so that its scheduler can do as good a job as possible. This PR is an initial attempt at setting these values, although we know you are much more likely to have insight into your components mem/cpu requirements than our guess.
If you have any questions or concerns, please let us know! Thanks!
#174462927
Co-Authored-By: Angela Chin achin@pivotal.io