Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Commit

Permalink
Use clearer name for newClusteringService()
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex Harford committed Aug 31, 2018
1 parent 1edd33f commit 345c29a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions kube/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ func NewServiceList(role *model.InstanceGroup, clustering bool, settings ExportS
var items []helm.Node

if clustering {
svc, err := newGenericService(role, settings)
svc, err := newClusteringService(role, settings)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -142,9 +142,9 @@ func createPorts(settings ExportSettings, serviceType newServiceType, roleName s
return ports
}

// newGenericService creates a new k8s service (ClusterIP or LoadBalanced) for the overall role.
// newClusteringService creates a new k8s service for the overall instance group.
// This allows individual pods to be addressed by their index.
func newGenericService(role *model.InstanceGroup, settings ExportSettings) (helm.Node, error) {
func newClusteringService(role *model.InstanceGroup, settings ExportSettings) (helm.Node, error) {
var ports []helm.Node
for _, job := range role.JobReferences {
for _, port := range job.ContainerProperties.BoshContainerization.Ports {
Expand Down

0 comments on commit 345c29a

Please sign in to comment.