This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
support diffing final releases. #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release-resolver: unify loading via releaseRefs release-resolver: use temporary files for URLs release-resolver: look up release info from final release tarballs cmd: skip normalizing release paths that look like URLs
|
✅ Hey mook-as! The commit authors and yourself have already signed the CLA. |
jandubois
suggested changes
Dec 6, 2018
There was a problem hiding this comment.
I'm going to block this because we are going to change how you specify release refs from the commandline for the fissile build release-images command (using --name, --sha1, --url, and --version options, so we can check if we have them in the local cache or not). I just discussed this earlier today with Vlad.
This change should then use the same mechanism.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455.
I don't like this much yet; there's a bit with a hard
://check that smells a bit. It's also a lot of change in code I'm not all that familiar with.🐛Bug: this seems to accidentally move the final releases dir, which means we'll need to re-download things again.