Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Update tests to Go 1.12 #474

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Update tests to Go 1.12 #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ agent.
## Getting fissile

### Prerequisites
Building fissile needs [Go 1.9] or higher and [Docker].
Building fissile needs [Go 1.12] or higher and [Docker].

[Go 1.9]: https://golang.org/doc/install
[Go 1.12]: https://golang.org/doc/install
[Docker]: https://www.docker.com

### Build procedure
Expand Down
18 changes: 9 additions & 9 deletions kube/deployment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func TestNewDeploymentHelm(t *testing.T) {
}
_, err := RenderNode(deployment, config)
assert.EqualError(err,
`template: :11:17: executing "" at <fail "some_group mus...>: error calling fail: some_group must have at least 1 instances`)
`template: :11:17: executing "" at <fail "some_group must have at least 1 instances">: error calling fail: some_group must have at least 1 instances`)
})

t.Run("Configured, not enough replicas", func(t *testing.T) {
Expand All @@ -118,7 +118,7 @@ func TestNewDeploymentHelm(t *testing.T) {
}
_, err := RenderNode(deployment, config)
assert.EqualError(err,
`template: :11:17: executing "" at <fail "some_group mus...>: error calling fail: some_group must have at least 1 instances`)
`template: :11:17: executing "" at <fail "some_group must have at least 1 instances">: error calling fail: some_group must have at least 1 instances`)
})

t.Run("Configured, too many replicas", func(t *testing.T) {
Expand All @@ -133,7 +133,7 @@ func TestNewDeploymentHelm(t *testing.T) {
}
_, err := RenderNode(deployment, config)
assert.EqualError(err,
`template: :7:17: executing "" at <fail "some_group can...>: error calling fail: some_group cannot have more than 1 instances`)
`template: :7:17: executing "" at <fail "some_group cannot have more than 1 instances">: error calling fail: some_group cannot have more than 1 instances`)
})

t.Run("Configured, bad key sizing.HA", func(t *testing.T) {
Expand All @@ -144,7 +144,7 @@ func TestNewDeploymentHelm(t *testing.T) {
}
_, err := RenderNode(deployment, config)
assert.EqualError(err,
`template: :15:21: executing "" at <fail "Bad use of mov...>: error calling fail: Bad use of moved variable sizing.HA. The new name to use is config.HA`)
`template: :15:21: executing "" at <fail "Bad use of moved variable sizing.HA. The new name to use is config.HA">: error calling fail: Bad use of moved variable sizing.HA. The new name to use is config.HA`)
})

t.Run("Configured, bad key sizing.memory.limits", func(t *testing.T) {
Expand All @@ -155,7 +155,7 @@ func TestNewDeploymentHelm(t *testing.T) {
}
_, err := RenderNode(deployment, config)
assert.EqualError(err,
`template: :27:70: executing "" at <fail "Bad use of mov...>: error calling fail: Bad use of moved variable sizing.memory.limits. The new name to use is config.memory.limits`)
`template: :27:70: executing "" at <fail "Bad use of moved variable sizing.memory.limits. The new name to use is config.memory.limits">: error calling fail: Bad use of moved variable sizing.memory.limits. The new name to use is config.memory.limits`)
})

t.Run("Configured, bad key sizing.memory.requests", func(t *testing.T) {
Expand All @@ -166,7 +166,7 @@ func TestNewDeploymentHelm(t *testing.T) {
}
_, err := RenderNode(deployment, config)
assert.EqualError(err,
`template: :31:74: executing "" at <fail "Bad use of mov...>: error calling fail: Bad use of moved variable sizing.memory.requests. The new name to use is config.memory.requests`)
`template: :31:74: executing "" at <fail "Bad use of moved variable sizing.memory.requests. The new name to use is config.memory.requests">: error calling fail: Bad use of moved variable sizing.memory.requests. The new name to use is config.memory.requests`)
})

t.Run("Configured, bad key sizing.cpu.limits", func(t *testing.T) {
Expand All @@ -177,7 +177,7 @@ func TestNewDeploymentHelm(t *testing.T) {
}
_, err := RenderNode(deployment, config)
assert.EqualError(err,
`template: :19:64: executing "" at <fail "Bad use of mov...>: error calling fail: Bad use of moved variable sizing.cpu.limits. The new name to use is config.cpu.limits`)
`template: :19:64: executing "" at <fail "Bad use of moved variable sizing.cpu.limits. The new name to use is config.cpu.limits">: error calling fail: Bad use of moved variable sizing.cpu.limits. The new name to use is config.cpu.limits`)
})

t.Run("Configured, bad key sizing.cpu.requests", func(t *testing.T) {
Expand All @@ -188,7 +188,7 @@ func TestNewDeploymentHelm(t *testing.T) {
}
_, err := RenderNode(deployment, config)
assert.EqualError(err,
`template: :23:68: executing "" at <fail "Bad use of mov...>: error calling fail: Bad use of moved variable sizing.cpu.requests. The new name to use is config.cpu.requests`)
`template: :23:68: executing "" at <fail "Bad use of moved variable sizing.cpu.requests. The new name to use is config.cpu.requests">: error calling fail: Bad use of moved variable sizing.cpu.requests. The new name to use is config.cpu.requests`)
})

t.Run("Configured", func(t *testing.T) {
Expand Down Expand Up @@ -600,7 +600,7 @@ func TestNewDeploymentWithEmptyDirVolume(t *testing.T) {
}
_, err := RenderNode(deployment, config)
assert.EqualError(err,
`template: :11:17: executing "" at <fail "some_group mus...>: error calling fail: some_group must have at least 1 instances`)
`template: :11:17: executing "" at <fail "some_group must have at least 1 instances">: error calling fail: some_group must have at least 1 instances`)
})

t.Run("Configured", func(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions kube/pod_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ func TestPodGetEnvVarsFromConfigNonSecretHelmUserRequired(t *testing.T) {
t.Parallel()
_, err := RenderNode(ev, nil)
assert.EqualError(err,
`template: :7:219: executing "" at <fail "env.SOMETHING ...>: error calling fail: env.SOMETHING has not been set`)
`template: :7:219: executing "" at <fail "env.SOMETHING has not been set">: error calling fail: env.SOMETHING has not been set`)
})

t.Run("Undefined", func(t *testing.T) {
Expand All @@ -1010,7 +1010,7 @@ func TestPodGetEnvVarsFromConfigNonSecretHelmUserRequired(t *testing.T) {
}
_, err := RenderNode(ev, config)
assert.EqualError(err,
`template: :7:219: executing "" at <fail "env.SOMETHING ...>: error calling fail: env.SOMETHING has not been set`)
`template: :7:219: executing "" at <fail "env.SOMETHING has not been set">: error calling fail: env.SOMETHING has not been set`)
})

t.Run("Present", func(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions kube/secret_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func TestMakeSecretsHelm(t *testing.T) {

_, err := RenderNode(secret, nil)
assert.EqualError(err,
`template: :6:237: executing "" at <fail "secrets.const ...>: error calling fail: secrets.const has not been set`)
`template: :6:237: executing "" at <fail "secrets.const has not been set">: error calling fail: secrets.const has not been set`)
})

t.Run("Undefined", func(t *testing.T) {
Expand All @@ -231,7 +231,7 @@ func TestMakeSecretsHelm(t *testing.T) {

_, err := RenderNode(secret, config)
assert.EqualError(err,
`template: :6:237: executing "" at <fail "secrets.const ...>: error calling fail: secrets.const has not been set`)
`template: :6:237: executing "" at <fail "secrets.const has not been set">: error calling fail: secrets.const has not been set`)
})

t.Run("Present", func(t *testing.T) {
Expand Down