This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
HCF-329: Generate spec store with BOSH releases as directories. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| @@ -71,6 +73,7 @@ ip_address=`/bin/hostname -i` | |||
| --consul "${consul_address}" \ | |||
| --prefix "${config_store_prefix}" \ | |||
| --role "{{$role.Name}}" \ | |||
| --release "" \ | |||
There was a problem hiding this comment.
This probably shouldn't be empty? Otherwise configgin's sprintf crap will look for /spec//job/key/name and despite that maybe working it feels gross.
There was a problem hiding this comment.
Fixed in 646fe1b - I've heard that roles have at least one job, so grabbing the release name off the first one is probably okay. (The resulting run.sh from a unit test run looks sane.)
This assumes that roles have at least one job, and the release name of the first job is acceptable. This assumption should be correct for now.
|
LGTM |
aarondl
added a commit
that referenced
this pull request
Nov 6, 2015
HCF-329: Generate spec store with BOSH releases as directories.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires coordination with cloudfoundry-incubator/configgin#16 - probably best to not merge until I figure out how to get a cluster built with all the changes to confirm that everything works the way I think they should.