This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
fix: Don't allow upgrades unless the embedded database is a singleton #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a chance of dataloss when we upgrade from HA to SA while also changing the chart version. And we no longer support an embedded HA database, so the user has to scale down before performing the upgrade.
jandubois
changed the title
jandubois
force-pushed
the
jandubois/database-instance-check
branch
from
064fbc9
to
1f67fd1
Compare
viovanov
approved these changes
Oct 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a chance of dataloss when we upgrade from HA to SA while also changing the chart version. And we no longer support an embedded HA database, so the user has to scale down before performing the upgrade.
Eventually this code (together with the "unsupported" logic) should be moved to its own template file.