Skip to content
This repository has been archived by the owner on Jul 3, 2021. It is now read-only.

Add ops-file to enable CSI shared mounts #355

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Add ops-file to enable CSI shared mounts #355

merged 1 commit into from
Dec 7, 2018

Conversation

davewalter
Copy link
Contributor

What this PR does / why we need it:

This PR adds an ops-file to allow operators to configure docker to enable shared mounts.

How can this PR be verified?

When the ops-file is applied, the docker job on the worker should be configured with shared_mounts_enable set to true.

Is there any change in kubo-release?

No.

Is there any change in kubo-ci?

No.

Does this affect upgrade, or is there any migration required?

No.

Which issue(s) this PR fixes:

This is required to configure CSI support in Kubernetes. See this doc for details.

Release note:

Added an ops-file to enable shared mounts for CSI support. See the [Kubernetes CSI Setup Documentation](https://kubernetes-csi.github.io/docs/Setup.html#enabling-mount-propagation) for details.

Please feel free to reach out if you have any questions.

Regards,
Dave

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/161736917

The labels on this github issue will be updated when the story is started.

@cfdreddbot
Copy link

Hey davewalter!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@alex-slynko
Copy link
Member

Hi @davewalter

Is there any reason not to include it as the default option in the main manifest?

I am assuming that mount propagation is required for all CSI volumes.

@julian-hj
Copy link
Member

@alex-slynko see https://docs.docker.com/v17.09/engine/admin/volumes/bind-mounts/#configure-bind-propagation for more details about what this setting does.

Basically, this is a setting that's necessary to run most CSI plugins in k8s, but degrades container security somewhat, since it allows mounts created within the container to leak out into the root namespace, and potentially back into other containers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants