Fixed route-sync ticker-based memory leak

Issue #140.

[#153211365]

Signed-off-by: Travis Hall <thall@vmware.com>

src/route-sync/pooler/pooler.go

@@ -52,15 +52,17 @@ func (tb *timeBased) tick(src route.Source, router route.Router) {
 }
 
 func (tb *timeBased) Run(ctx context.Context, src route.Source, router route.Router) {
-	timer := time.Tick(1)
+	ticker := time.NewTicker(tb.interval)
+	defer ticker.Stop()
+
+	tb.tick(src, router)
 
 	for {
 		select {
 		case <-ctx.Done():
 			return
-		case <-timer:
+		case <-ticker.C:
 			tb.tick(src, router)
-			timer = time.Tick(tb.interval)
 		}
 	}
 }

src/route-sync/pooler/pooler_test.go

@@ -29,7 +29,7 @@ var _ = Describe("Time-based Pooler", func() {
 
 	BeforeEach(func() {
 		logger = lagertest.NewTestLogger("")
-		pool = pooler.ByTime(time.Duration(0), logger)
+		pool = pooler.ByTime(time.Duration(1), logger)
 		src = &routefakes.FakeSource{}
 
 		tcpRoutes = []*route.TCP{