Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Commit

Permalink
Use plus instead of dash in version number
Browse files Browse the repository at this point in the history
Helm follows semantic versioning and considers any version with dash to
be a pre-release.  Pre-releases are not found in search unless `--devel`
is used.
  • Loading branch information
Mario Manno committed Feb 3, 2020
1 parent 62fcf84 commit 8fa45f0
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion bin/build-helm
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ GIT_ROOT=${GIT_ROOT:-$(git rev-parse --show-toplevel)}
. "${GIT_ROOT}/bin/include/docker"

output_dir=${GIT_ROOT}/helm
version=$(echo "$ARTIFACT_VERSION" | sed 's/^v//')

# https://semver.org/#semantic-versioning-200
# helm does not accept ^v and considers any version with dash to be a
# pre-release
version=$(echo "$ARTIFACT_VERSION" | sed 's/^v//; s/-/+/')
filename="${output_dir}/${ARTIFACT_NAME}-${version}.tgz"

[ -d "${output_dir}" ] && rm -r "${output_dir}"
Expand Down

0 comments on commit 8fa45f0

Please sign in to comment.