Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

add support for generating basic-auth secret types #6

Merged
merged 6 commits into from
Jul 6, 2020
Merged

add support for generating basic-auth secret types #6

merged 6 commits into from
Jul 6, 2020

Conversation

tomkennedy513
Copy link
Member

  • allow for optionally passing in username instead of generating

Co-authored-by: Aidan Obley aobley@vmware.com

- allow for optionally passing in username instead of generating

Co-authored-by: Aidan Obley <aobley@vmware.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 30, 2020

CLA Check
The committers are authorized under a signed CLA.

Copy link
Member

@edwardstudy edwardstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manno
Copy link
Member

manno commented Jul 2, 2020

@tomkennedy513 sorry about the red integration test, we have this check if all examples have a test. Mostly works the other way around and checks if we remembered to increase the number...

@peterhaochen47
Copy link
Member

peterhaochen47 commented Jul 2, 2020

@edwardstudy Added doc.

@manno Is there something we should do to fix the test failures? Is there a number we should bump somewhere?

@manno
Copy link
Member

manno commented Jul 3, 2020

@manno Is there something we should do to fix the test failures? Is there a number we should bump somewhere?

Hey, yes the tests fail here: e2e/kube/examples_count_test.go:12

@manno manno dismissed edwardstudy’s stale review July 6, 2020 11:06

docs were added

@manno manno merged commit 4f51b42 into cloudfoundry-incubator:master Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants