This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Deploy App Manifest overrides #2924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2924 +/- ##
=============================================
- Coverage 71.22% 71.19% -0.04%
=============================================
Files 606 607 +1
Lines 25982 26106 +124
Branches 5893 5910 +17
=============================================
+ Hits 18506 18585 +79
- Misses 7476 7521 +45 |
Still need to.. - Store overrides in app env var - Ensure redeploy flow works correctly (includes disabled state, showing original values, next button texts) - Show drop down for domains
- Add temp step size fix for create app's create route + register endpoint - Add domains list - Store overrides in stratos env var and load on redeploy
nwmac
commented
Sep 6, 2018
| @@ -159,11 +168,20 @@ export class DeployApplicationDeployer { | |||
| this.inputStream.next(JSON.stringify(msg)); | |||
| } | |||
|
|
|||
| sentAppOverride = (appOverrides: OverrideAppDetails) => { | |||
| sendEvent(clientWebSocket, OVERRIDES_REQUIRED) | ||
|
|
||
| // Wait for a message from the client | ||
| log.Info("Waiting for app overrides from client") |
| return err | ||
| } | ||
|
|
||
| log.Infof("Overrides: %v+", msgOverrides) |
There was a problem hiding this comment.
Check message type is OVERRIDES_SUPPLIED
| @@ -100,22 +125,23 @@ func (cfAppPush *CFAppPush) deploy(echoContext echo.Context) error { | |||
| return err | |||
| } | |||
|
|
|||
| log.Infof("%v+", msg) | |||
| log.Infof("Source %v+", msg) | |||
|
|
||
| var flags []string | ||
|
|
||
| if len(overrides.Name) != 0 { |
There was a problem hiding this comment.
Could possible factor out to a helper function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extra (optional) step to the Deploy App flow to allow manifest overrides to be provided.