Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

User menu improvements #3136

Merged
merged 9 commits into from
Oct 23, 2018
Merged

User menu improvements #3136

merged 9 commits into from
Oct 23, 2018

Conversation

KlapTrap
Copy link
Contributor

fixes #3076

See ticket for details

@cfdreddbot
Copy link

Hey KlapTrap!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

* v2-master: (30 commits)
  Fix e2e test
  Update lock file
  Fix example
  Ensure extention buttons appear on the right, not next to the title
  Fix compilation error due to logoText not being added to CuistomizatonsMetadata
  Compile fix and theme tweak
  Endpoints Table: Only show 'Admin' check icon for cf endpoints
  Tidy up and fixes
  Move extension buttons component into the page header
  Fix user mgmt nav issue
  Better fix for user mgmt stepper not being able to cancel
  Fix for cancel not working for user management dialog
  Fix merge issue
  Remove white space
  Remove whitespace to fix lint issue
  Remove old depenency
  Fix Extension init
  Tidy ups
  Remove comma
  Add example
  ...
@KlapTrap
Copy link
Contributor Author

screen shot 2018-10-18 at 12 13 32

@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #3136 into v2-master will increase coverage by 0.05%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           v2-master    #3136      +/-   ##
=============================================
+ Coverage      71.11%   71.16%   +0.05%     
=============================================
  Files            630      630              
  Lines          27572    27575       +3     
  Branches        6270     6271       +1     
=============================================
+ Hits           19608    19625      +17     
+ Misses          7964     7950      -14

@irfanhabib
Copy link
Contributor

LGTM

@irfanhabib irfanhabib merged commit 21fca4e into v2-master Oct 23, 2018
@irfanhabib irfanhabib deleted the user-menu-improvements branch October 23, 2018 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Three-dots" menu item is in the wrong place
3 participants