Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Fix issue where org level user lists shows space roles from other orgs #3399

Merged
merged 3 commits into from Feb 19, 2019

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Feb 13, 2019

  • blocked on Scale Users in CF Summary section #3371
  • To reproduce..
    • user1 is user of org1, org2 and space dev in org1's space1
    • user2 is user of org1, org2 and space dev in org2's space1
    • connect to cf using user1 and navigate to org2's users list
    • user1 space cell showns their space role from org1
  • Explenation
    • user1 cannot see org2's space, so should not see any space roles at org2 level
    • cell receives a list of spaces that it should show roles for
    • empty spaces list for user1 in org2 was being converted to null
    • cell therefore thought it should show all of users spaces
  • I've tracked this change back and it was in from the start of the user pill with space prefix work
  • Have tested with
    • admin who can see all users and their roles at cf, org and space level
    • user2 who has limited visibility of spaces at org and space levels (no cf users table for non-admins)

- To reproduce..
  - user1 is user of org1, org2 and space dev in org1's space1
  - user2 is user of org1, org2 and space dev in org2's space1
  - connect to cf using user1 and navigate to org2's users list
  - user1 space cell showns their space role from org1
- Explenation
  - user1 cannot see org2's space, so should not see any space roles at org2 level
  - cell receives a list of spaces that it should show roles for
  - empty spaces list for user1 in org2 was being converted to null
  - cell therefore thought it should show all of users spaces
- I've tracked this change back and it was in from the start of the user pill with space prefix work
- Have tested with
  - admin who can see all users and their roles at cf, org and space level
  - user2 who has limited visibility of spaces at org and space levels (no cf users table for non-admins)
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #3399 into v2-master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##           v2-master   #3399      +/-   ##
============================================
- Coverage      70.31%   70.3%   -0.01%     
============================================
  Files            693     693              
  Lines          30727   30727              
  Branches        6995    6994       -1     
============================================
- Hits           21606   21604       -2     
- Misses          9121    9123       +2

@KlapTrap KlapTrap merged commit 6345314 into v2-master Feb 19, 2019
@KlapTrap KlapTrap deleted the fix-visible-space-roles branch February 19, 2019 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants