Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Always build with go modules #3589

Merged
merged 1 commit into from
May 16, 2019
Merged

Always build with go modules #3589

merged 1 commit into from
May 16, 2019

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented May 15, 2019

Ensure we set GO111MODULE=on so that building from GOPATH still works

@nwmac nwmac self-assigned this May 15, 2019
@cfdreddbot
Copy link

✅ Hey nwmac! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #3589 into v2-master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v2-master    #3589   +/-   ##
==========================================
  Coverage      51.83%   51.83%           
==========================================
  Files            720      720           
  Lines          20224    20224           
  Branches        3613     3613           
==========================================
  Hits           10484    10484           
  Misses          9740     9740

Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once passed gates

@richard-cox richard-cox merged commit 727fa35 into v2-master May 16, 2019
@richard-cox richard-cox deleted the add-go-mod-flag branch May 16, 2019 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants