This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Ensure we remove X-Forward-* HTTP headers that can cause problems proxying API requests #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nwmac! The commit authors and yourself have already signed the CLA. |
nwmac
changed the title
Codecov Report
@@ Coverage Diff @@
## v2-master #3934 +/- ##
=============================================
+ Coverage 52.21% 52.22% +<.01%
=============================================
Files 785 785
Lines 23017 23017
Branches 4124 4124
=============================================
+ Hits 12019 12020 +1
+ Misses 10998 10997 -1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load balancers can add headers - X-Forwarded-Host and X-Forwarded-Port - these cause problems when we proxy requests to Cloud Foundry when Stratos is behind a load balancer